Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads history shows date of 12/31/1969 #6088

Closed
mbacchi opened this issue Sep 19, 2019 · 7 comments
Closed

Ads history shows date of 12/31/1969 #6088

mbacchi opened this issue Sep 19, 2019 · 7 comments
Assignees
Labels

Comments

@mbacchi
Copy link
Contributor

mbacchi commented Sep 19, 2019

Description

Brave ads history page shows the date of 12/31/1969 for ads in the past 7 days:

image

Steps to Reproduce

  1. Enable ads
  2. Go to 7 day ad history

Actual result:

Screenshot above

Expected result:

Date of each ad shown is unique, and more recent than the start of the epoch counter.

Reproduces how often:

Always

Brave version (brave://version info)

Development version Version 0.71.74 Chromium: 77.0.3865.75 (Official Build) dev (64-bit)
OS: Linux

Version/Channel Information:

Unsure, only use ads on dev channel at the moment.

  • Can you reproduce this issue with the current release? Ads not currently enabled, will enable them to test now.
  • Can you reproduce this issue with the beta channel? Ads not currently enabled, will enable them to test now.
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Ads not currently enabled, will enable them to test now.

Other Additional Information:

Miscellaneous Information:

@btlechowski
Copy link

Reproduced on

Brave 0.70.116 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Date is 1970/1/1 though.

image

cc @brave/legacy_qa

@LaurenWags
Copy link
Member

cc @alexwykoff

@btlechowski
Copy link

Reproduced on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux

image

Could be Linux only issue. cc @GeetaSarvadnya @LaurenWags to check on other platforms.

@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 21, 2019
@GeetaSarvadnya
Copy link

@atharvan
Copy link

Reproduced on

Brave 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Linux

Date 01/01/1970

@tmancey tmancey self-assigned this Dec 1, 2019
@tmancey
Copy link
Contributor

tmancey commented Dec 5, 2019

Closing issue as should be resolved by #6757

@LaurenWags can you please test as part of #6757

@tmancey tmancey closed this as completed Dec 5, 2019
@tmancey tmancey added the QA/Yes label Dec 5, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Dec 17, 2019
@btlechowski btlechowski modified the milestones: Dupe / Invalid / Not actionable, 1.4.x - Beta Feb 12, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified steps from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants