Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads enabled by default for Japan on upgrade #3691

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 14, 2019

Fixes brave/brave-browser#6449

Submitter Checklist:

Test Plan:

  • Confirm ads are not enabled by default for upgrade paths for new regions
  • Confirm ads are enabled by default for fresh installs if a region is supported and rewards is enabled
  • Confirm on-boarding is shown for upgrade paths for new regions

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

emerick
emerick previously approved these changes Oct 14, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from emerick October 14, 2019 14:52
Copy link
Contributor

@masparrow masparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@tmancey tmancey merged commit b8cd01b into master Oct 15, 2019
@tmancey tmancey deleted the issues/6449 branch October 15, 2019 13:14
@btlechowski
Copy link

LGTM, encountered few known issues while testing.

Brave 0.72.103 Chromium: 78.0.3904.50 (Official Build) nightly (64 ビット)
変更履歴 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Linux

Clean install, Japanese locale
Verified ads were enabled when rewards were enabled
Verified viewing an ad
Verified ads viewed increased in brave://rewards ads section
image

Upgrade from 0.69.x, Japanese locale
Verified ads are turned off by default on 0.69.x
image
Verified ads are turned off after upgrade to 0.72.x
Verified notification about ads available is shown after upgrade to 0.72.x
image
Verified that ads are not displayed after upgrade to 0.72.x
Verified clicking on Enable Ads in notification, opens brave://rewards
Verified that turning on ads, show the ads 0.72.x
image
Verified viewing an ad.
Verified ads viewed increased in brave://rewards ads section
Verified ad was added to ads history

Encountered brave/brave-browser#6088 brave/brave-browser#6207

Clean install, US locale
Verified ads were enabled when rewards were enabled
Verified viewing an ad
Verified ads viewed increased in brave://rewards ads section

Upgrade from 0.69.x, US locale
Verified ads are turned on by default on 0.69.x after enabling rewards
Verified ads are turned on after upgrade
Verified ads history retained after upgrade
Verified viewing an ad

Encountered brave/brave-browser#6270 (comment) when ads are turned off in 0.69.x

Clean install, Polish locale
Verified ads were enabled when rewards were enabled
Verified viewing an ad
Verified ads viewed increased in brave://rewards ads section

Upgrade from 0.69.x, Polish locale
Verified ads are turned off by default on 0.69.x
Verified ads are turned off after upgrade to 0.72.x
Verified notification about ads available is shown after upgrade to 0.72.x
Verified that ads are not displayed after upgrade to 0.72.x
Verified clicking on Enable Ads in notification, opens brave://rewards
Verified that turning on ads, show the ads 0.72.x
Verified viewing an ad.
Verified ads viewed increased in brave://rewards ads section
Verified ad was added to ads history

Clean install, Italian locale
Verified ads were enabled when rewards were enabled
Verified viewing an ad
Verified ads viewed increased in brave://rewards ads section

Upgrade from 0.69.x, Italian locale
Verified ads are turned off by default on 0.69.x
Verified ads are turned off after upgrade to 0.72.x
Verified notification about ads available is shown after upgrade to 0.72.x
Verified that ads are not displayed after upgrade to 0.72.x
Verified clicking on Enable Ads in notification, opens brave://rewards
Verified that turning on ads, show the ads 0.72.x
Verified viewing an ad.
Verified ads viewed increased in brave://rewards ads section
Verified ad was added to ads history

@tmancey tmancey changed the title Ads enabled by default for Japan on upgrade Fixes ads enabled by default for Japan on upgrade Oct 16, 2019
@kjozwiak
Copy link
Member

@btlechowski awesome job on verifying this fix against Nightly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ads enabled by default for Japan on upgrade
5 participants