-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ads enabled by default for Japan on upgrade #3691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me
LGTM, encountered few known issues while testing.
Clean install, Japanese locale Upgrade from 0.69.x, Japanese locale Encountered brave/brave-browser#6088 brave/brave-browser#6207 Clean install, US locale Upgrade from 0.69.x, US locale Encountered brave/brave-browser#6270 (comment) when ads are turned off in 0.69.x Clean install, Polish locale Upgrade from 0.69.x, Polish locale Clean install, Italian locale Upgrade from 0.69.x, Italian locale |
@btlechowski awesome job on verifying this fix against Nightly 👍 |
Fixes brave/brave-browser#6449
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.