Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in line tipping for reddit does not show the post you are trying to tip - follow up to 4907 #6252

Closed
LaurenWags opened this issue Oct 1, 2019 · 2 comments · Fixed by brave/brave-core#3592

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #4907

If I am on reddit and click on the inline tip button for a comment, the tip banner should show the post I'm tipping. The post is not shown in the tip banner on 0.69.x.

Steps to Reproduce

  1. Enable Rewards
  2. Navigate to https://www.reddit.com/user/jonathansampson
  3. Click on in-line tip button for a comment/post.

Actual result:

Post you are tipping is not shown on tip banner:
Screen Shot 2019-10-01 at 11 04 32 AM

Expected result:

Should show post being tipped like in 0.68.142:
Screen Shot 2019-10-01 at 10 59 34 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.68.x no, 0.69.x yes
  • Can you reproduce this issue with the beta channel? unsure, probably yes
  • Can you reproduce this issue with the dev channel? 0.71.x yes
  • Can you reproduce this issue with the nightly channel? 0.72.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa @rebron

@masparrow
Copy link

Related to #6223

@btlechowski
Copy link

btlechowski commented Oct 29, 2019

Verification passed on

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified STR from the description. Verified new and old reddit. Tested on production and staging env.

image
image
image

Verified passed with

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description. Verified for reddit.com and old.reddit.com.

Screen Shot 2019-11-14 at 3 24 32 PM

Screen Shot 2019-11-14 at 3 28 10 PM

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description. Verified for reddit.com and old.reddit.com.
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment