Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backup/restore notification for verified wallet users #6259

Closed
mandar-brave opened this issue Oct 1, 2019 · 6 comments · Fixed by brave/brave-core#6344
Closed

Remove backup/restore notification for verified wallet users #6259

mandar-brave opened this issue Oct 1, 2019 · 6 comments · Fixed by brave/brave-core#6344

Comments

@mandar-brave
Copy link

mandar-brave commented Oct 1, 2019

backup functionality is now limited, and more users keep their BAT using a Custodial wallet, so we should only show backup notification once after 30 days of usage. If user connects uphold KYC wallet we should never display it.

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 1, 2019
@NejcZdovc
Copy link
Contributor

@mandar-brave why? user could still have ugp in their wallet and they would loose it. Also payment id is connected to ads earnings

@NejcZdovc NejcZdovc added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@ethanbb
Copy link

ethanbb commented Jan 4, 2020

For me this keeps showing up again and again even though I backed up my wallet a long time ago, i.e. copied the recovery key to a secure note in LastPass. I also have a verified wallet with Uphold. Is this a bug or what?

@mandar-brave
Copy link
Author

@ethanbb the reason it shows it because it does that at a once a month cadence; this is just to ensure user doesn't forget.

@NejcZdovc we should have a never show again option; lets chat and design UX accordingly.

@PandaWhisperer
Copy link

Sorry for hijacking this thread, but is there a way to turn off the backup reminder (or change its frequency)? I've got mine backed up securely and the constant reminders are getting annoying.

@mandar-brave
Copy link
Author

@NejcZdovc as backup functionality is now limited, and more users keep their BAT using a Custodial wallet, please go ahead and limit this to once to get user acquainted.

@LaurenWags
Copy link
Member

LaurenWags commented Sep 2, 2020

Verified passed with

Brave | 1.14.72 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified Case 1 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was shown after 5s.
  • Confirmed after clicking on the x icon, the notification did not show again after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

Verified Case 2 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was not shown after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

for reference, this is how I updated my Preferences file for both cases per the PR:

Screen Shot 2020-09-02 at 3 15 41 PM


Verification passed on

Brave | 1.14.74 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified Case 1 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was shown after 5s.
  • Confirmed after clicking on the x icon, the notification did not show again after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

Verified Case 2 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was not shown after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

Verification passed on

Brave 1.14.75 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Verified Case 1 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was shown after 5s.
  • Confirmed after clicking on the x icon, the notification did not show again after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

Verified Case 2 from brave/brave-core#6344

  • Confirmed after updating Preferences file as directed and relaunching, the backup notification was not shown after 5s.
  • Closed and relaunched. Confirmed notification again did not show after 5s.
  • Set date forward on my computer by 1 month and launched. Confirmed notification did not show after 5s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment