Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and migrate Rewards category from category to type #6350

Closed
tmancey opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#3630
Closed

Refactor and migrate Rewards category from category to type #6350

tmancey opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#3630
Assignees
@tmancey
Labels
dev-concern feature/rewards perf priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.70.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 8, 2019

No description provided.

@tmancey tmancey added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. perf dev-concern labels Oct 8, 2019
@tmancey tmancey added this to the 0.72.x - Nightly milestone Oct 8, 2019
@tmancey tmancey self-assigned this Oct 8, 2019
@tmancey tmancey removed this from the 0.72.x - Nightly milestone Oct 8, 2019
This was referenced Oct 8, 2019
Merged
Closed
@tmancey tmancey added the QA/Yes label Oct 8, 2019
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Oct 9, 2019
tmancey added a commit to brave/brave-core that referenced this issue Oct 9, 2019
@tmancey
Refactored and migrated Rewards category from category to type
27c2c6f 
Fixes brave/brave-browser#6350
@LaurenWags
Copy link
Member

Marking as QA/Blocked until the test plan is understood better. Additional detail/clarification requested from @tmancey .

@LaurenWags
Copy link
Member

Test plan on PR updated, removed QA/Blocked label. Thanks @tmancey !

This was referenced Oct 22, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Oct 22, 2019 •
edited by kjozwiak
Loading

Verified passed with

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from Refactored and migrated Rewards category from category to type brave-core#3630
  • Confirmed Auto Contributions (AC and recurring tips) work as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Auto Contributions (AC and recurring tips) work as expected for a fresh install of 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected for a fresh install of 0.70.120.

Screen Shot 2019-10-22 at 3 31 05 PM

Screen Shot 2019-10-22 at 3 31 18 PM

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified test plan from Refactored and migrated Rewards category from category to type brave-core#3630
  • Confirmed Auto Contributions (AC and recurring tips) work as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Auto Contributions (AC and recurring tips) work as expected for a fresh install of 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected for a fresh install of 0.70.120.

6350

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Refactored and migrated Rewards category from category to type brave-core#3630
  • Confirmed Auto Contributions (AC and recurring tips) work as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Auto Contributions (AC and recurring tips) work as expected for a fresh install of 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected for a fresh install of 0.70.120.

image

image

Verification PASSED on Win 10 x64 using the following build:

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1809 (Build 17763.805)
  • Verified test plan from Refactored and migrated Rewards category from category to type brave-core#3630
  • Confirmed Auto Contributions (AC and recurring tips) work as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected after an upgrade from 0.69.135 to 0.70.120
  • Confirmed Auto Contributions (AC and recurring tips) work as expected for a fresh install of 0.70.120
  • Confirmed Pending Contributions (adding sites to the pending list) works as expected for a fresh install of 0.70.120.

Annotation 2019-10-24 043610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/rewards perf priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Refactored and migrated Rewards category from category to type brave/brave-core
5 participants
@tmancey @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya