Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode does not work for the new tab Remove menu #6395

Closed
cndouglas opened this issue Oct 10, 2019 · 2 comments · Fixed by brave/brave-core#4423
Closed

Dark mode does not work for the new tab Remove menu #6395

cndouglas opened this issue Oct 10, 2019 · 2 comments · Fixed by brave/brave-core#4423

Comments

@cndouglas
Copy link
Contributor

cndouglas commented Oct 10, 2019

Test plan

See brave/brave-core#4423

Description

Follow up to #5014

The new tab Remove menu does not work with dark mode.

Steps to Reproduce

  1. Open Settings and set Brave colors to Dark.
  2. Open the new tab page and click one of the drop down buttons next to one of the new tab page elements.

Actual result:

The menu is light even when dark mode is enabled.

Expected result:

The menu should be dark, like the settings popup.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave | 0.72.83 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS | macOS Version 10.15 (Build 19A583)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Not applicable.
  • Does the issue resolve itself when disabling Brave Rewards? Not applicable.
  • Is the issue reproducible on the latest version of Chrome? Not applicable.

Miscellaneous Information:

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 18, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 18, 2019

@cezaraugusto Can you take a look?

@cezaraugusto cezaraugusto self-assigned this Oct 22, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 24, 2020
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 29, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 10, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 13, 2020
@bsclifton bsclifton added this to the 1.6.x - Nightly milestone Feb 19, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this issue Mar 11, 2020
@btlechowski
Copy link

btlechowski commented Mar 18, 2020

Verification passed on

Brave 1.7.65 Chromium: 80.0.3987.132 (Official Build) dev (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4423

Light theme

image
image
image
image
image

Dark theme
image
image
image
image
image


Verified passed with

Brave 1.7.66 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Dark theme:
Screen Shot 2020-03-19 at 1 17 19 PM

Light theme:
Screen Shot 2020-03-19 at 1 17 43 PM

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment