-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode does not work for the new tab Remove menu #6395
Labels
feature/new-tab
feature/themes
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
@cezaraugusto Can you take a look? |
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jan 24, 2020
32 tasks
rebron
added
priority/P3
The next thing for us to work on. It'll ride the trains.
and removed
priority/P4
Planned work. We expect to get to it "soon".
labels
Jan 29, 2020
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Feb 10, 2020
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Feb 13, 2020
jonathanKingston
pushed a commit
to jonathanKingston/brave-core
that referenced
this issue
Mar 11, 2020
Verification passed on
Verified test plan from brave/brave-core#4423 Light theme Verified passed with
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/new-tab
feature/themes
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Test plan
See brave/brave-core#4423
Description
Follow up to #5014
The new tab Remove menu does not work with dark mode.
Steps to Reproduce
Brave colors
toDark
.Actual result:
The menu is light even when dark mode is enabled.
Expected result:
The menu should be dark, like the settings popup.
Reproduces how often:
Always.
Brave version (brave://version info)
Brave | 0.72.83 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS | macOS Version 10.15 (Build 19A583)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: