Unable to dismiss the first rewards notification

[btlechowski]

The first rewards notification reappears after browser restart

Steps to Reproduce

1. Clean install
2. Click BAT icon in URL bar -> first rewards notification is dismissed (expected)
3. Restart Brave

Actual result:

first rewards notification is shown

Expected result:

first rewards notification is dismissed

Broader test plan (from the PR via @petemill)

0. Clean user data directory
1. Launch Brave
2. Create a second profile via App Menu -> Create a New Profile
3. Expected: Both profile windows have the rewards icon with the badge text "1"
4. Click the rewards button in the second profile window
5. Expected: The second profile window's rewards icon does not have a badge
6. Expected: The first profile window's rewards icon does have a badge
7. Quit the browser
8. Start the browser again
9. Expected: The rewards icon badge state from each profile window is the same as 5) and 6)

Reproduces how often:

Always

Brave version (brave://version info)

Reproducible on

Brave	0.71.106 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Brave	0.72.112 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Brave	0.73.45 Chromium: 78.0.3904.70 (Official Build) nightly (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Not reproducible on

Brave	0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @NejcZdovc @petemill

[btlechowski]

@rebron @bsclifton While this is a visual only issue, it is a regression. Could you prioritize it?

[bsclifton]

marked as release-notes/exclude since it's not reproducible on 0.70.x

[LaurenWags]

Verified passed with

Brave	0.71.113 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision	20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS	macOS Version 10.13.6 (Build 17G5019)

• Reproduced issue using 0.71.108
• Verified STR from description
• Verified test plan from Rewards button pre-opt-in badge dismisses after first button press brave-core#3898

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Original issue reproduced in 0.71.108
• Verified STR from the description
• Verified test plan from Rewards button pre-opt-in badge dismisses after first button press brave-core#3898

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

• Verified STR from the description
• Verified test plan from Rewards button pre-opt-in badge dismisses after first button press brave-core#3898