Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.71.x: Uplift #3898 (Rewards button pre-opt-in badge dismisses after first button press) #3914

Merged
merged 1 commit into from
Nov 8, 2019
Merged

0.71.x: Uplift #3898 (Rewards button pre-opt-in badge dismisses after first button press) #3914

merged 1 commit into from
Nov 8, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 7, 2019

Uplifts #3898 to 0.71.x

We use a new pref to store the "badge text" value. Whilst we could store a boolean value whose state would be "has dismissed notification" (or not), this method is more future proof for having multiple variations of badge text, especially if or when this button becomes 'native' all the time (i.e. not an extension icon where the badge is controlled via JS).

Fix brave/brave-browser#6691

@bsclifton @petemill
Merge pull request #3898 from brave/rewards-stub-dismiss-badge
b05b4f1 
Rewards button pre-opt-in badge dismisses after first button press
@petemill petemill requested a review from NejcZdovc as a code owner November 7, 2019 18:08
@petemill petemill requested review from a team and removed request for NejcZdovc November 7, 2019 18:08
@petemill petemill self-assigned this Nov 7, 2019
@bsclifton bsclifton added this to the 0.71.x - Release milestone Nov 7, 2019
@petemill petemill changed the title 0.71.x: Uplift 3898 (Rewards button pre-opt-in badge dismisses after first button press) 0.71.x: Uplift #3898 (Rewards button pre-opt-in badge dismisses after first button press) Nov 7, 2019
kjozwiak
kjozwiak approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins & CI/Travis passed without any failures. Please make sure that the correct labels are being used and the associated issue is moved into the correct milstone.

@bsclifton bsclifton merged commit 2f2b51d into 0.71.x Nov 8, 2019
@bsclifton bsclifton deleted the rewards-stub-dismiss-badge-0.71.x branch November 8, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@petemill @kjozwiak @bsclifton