Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP Widget should indicate when Ads are not supported in the users region #6759

Closed
ryanml opened this issue Nov 4, 2019 · 2 comments · Fixed by brave/brave-core#3876
Closed

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 4, 2019

Design:
Screen Shot 2019-11-04 at 7 29 51 PM

Test plan:

  1. Start Browser
  2. Enable Rewards
  3. Ensure that toggling Ads on and off shows no regressions in behavior for the NTP widget
  4. Close browser
  5. Open Preferences file and search for countryid_at_install
  6. Replace value with a country id where ads are not supported
  7. Restart Browser
  8. Confirm that the NTP widget shows the unsupported messaging
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 8, 2019

Verification passed on

Brave 0.74.11 Chromium: 78.0.3904.87 (Official Build) nightly (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the description
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in a clean profile 0.74.11
    image
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in an upgraded profile 0.74.11, the message also displayed in Ads panel. (Upgraded build from 0.62.51 to 0.74.11)
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in an upgraded profile 0.74.11, the message also displayed in Ads panel. (Upgraded build from 0.68.69 to 0.74.11)
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in an upgraded profile 0.74.11, the message also displayed in Ads panel. (Upgraded build from 0.70.54 to 0.74.11)
  • Turn off rewards and exit brave, enable rewards message is shown in NTP and click on it enables the rewards and ads not supported message is displayed as expected in NTP widget as well as in Ads panel. Also, ensured catalog is empty for ads not supported regions, verified both clean and upgraded profile.
  • View an ad in ads supported region and change the region to ads not supported country and launch the profile where ad is viewed. --> Verified Sorry! Ads not yet available... message displayed in NTP widget and in ads panel as expected.
  • Change the region from not ads supported region to a supported region (use the same profile which is used in the above case) and launch the profile --> Verified viewed Ad estimated rewards count retained in NTP widget and same is displayed in ads panel, viewed few more ads in the same profile and ensured estimated rewards ads count is increased properly in NTP widget as well as in ads panel.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 11, 2019

Verified passed with

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified NTP widget shows Sorry!... message on clean install of non-ads region (Bulgaria). Verified Tips and contributions... increments as expected.
  • Verified NTP widget shows Sorry!... message on upgraded profile (from 0.70.123) for non-ads region (Bulgaria). Verified Tips and contributions... showed as expected on upgrade. Verified it also incremented after use on upgrade as well.
  • Verified that turning off rewards and exiting Brave, the enable rewards message is shown in NTP. Clicking on it enables the rewards and ads not supported message is displayed as expected in NTP widget as well as in Ads panel.

Screen Shot 2019-11-11 at 10 29 33

Screen Shot 2019-11-11 at 10 29 46

Screen Shot 2019-11-11 at 10 31 25

Verification is in-progress

Brave 0.71.114 Chromium: 78.0.3904.97 (Официално издание) (64 бита)
Ревизия 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
ОС Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the description
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in a clean profile 0.71.114
    image
    image
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in an upgraded profile 0.71.114, the message also displayed in Ads panel. (Upgraded build from 0.62.51 to 0.71.114)
  • Verified Sorry! Ads not yet available... message displayed in NTP widget for ads not supported country Bulgaria in an upgraded profile 0.71.114, the message also displayed in Ads panel. (Upgraded build from 0.70.123 to 0.71.114)
    image

image

  • Turn off rewards and exit brave, enable rewards message is shown in NTP and click on it enables the rewards and ads not supported message is displayed as expected in NTP widget as well as in Ads panel. Also, ensured catalog is empty for ads not supported regions, verified both clean and upgraded profile.

  • View an ad in ads supported region and change the region to ads not supported country and launch the profile where ad is viewed. --> Verified Sorry! Ads not yet available... message displayed in NTP widget and in ads panel as expected.

  • Change the region from not ads supported region to a supported region (use the same profile which is used in the above case) and launch the profile --> Verified viewed Ad estimated rewards count retained in NTP widget and same is displayed in ads panel, viewed few more ads in the same profile and ensured estimated rewards ads count is increased properly in NTP widget as well as in ads panel.

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified NTP widget shows Sorry!... message on clean install of non-ads region (Bulgaria). Verified Tips and contributions... increments as expected.
  • Verified NTP widget shows Sorry!... message on upgraded profile (from 0.70.123) for non-ads region (Bulgaria). Verified Tips and contributions... showed as expected on upgrade. Verified it also incremented after use on upgrade as well.
  • Verified that turning off rewards and exiting Brave, the enable rewards message is shown in NTP. Clicking on it enables the rewards and ads not supported message is displayed as expected in NTP widget as well as in Ads panel.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment