Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muli being listed twice under "brave://credits" #6881

Closed
kjozwiak opened this issue Nov 12, 2019 · 3 comments
Closed

Muli being listed twice under "brave://credits" #6881

kjozwiak opened this issue Nov 12, 2019 · 3 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 12, 2019

Description

Looks like Muli is being listed twice under brave://credits using 0.71.114 CR: 78.0.3904.97 which should have included 88c9110 as per https://github.com/brave/brave-core/commits/0.71.x.

Steps to Reproduce

  1. launch brave (used 0.71.114 CR: 78.0.3904.97 in this instance)
  2. visit brave://credits and search for Muli

Actual result:

Screen Shot 2019-11-11 at 8 36 02 PM

Expected result:

Muli should only be listed once under brave://credits

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa @rebron @bsclifton @fmarier

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 0.71.114

@fmarier
Copy link
Member

fmarier commented Nov 12, 2019

The root cause for this is #6832.

@btlechowski
Copy link

btlechowski commented Nov 28, 2019

Verification passed on

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

Verification passed on

Brave 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description
    image

Verified passed with

Brave 1.3.86 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description

Screen Shot 2020-01-08 at 4 12 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment