-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate fonts #4004
Remove duplicate fonts #4004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewards changes looks good
c0132a4
to
15f8caa
Compare
This looks good but I'd like to test out some rendering and webpack bundling, which I won't be able to get to until Wednesday. If it's more pressing than that, go ahead and merge following others' approval and I'll create follow up issues if I find anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@petemill It can wait until Wednesday, no problems. |
…wser#6881) By moving third-party fonts to the standard directory pattern for third-party code in Chromium, we don't have to teach the license script about our extra path.
15f8caa
to
d457807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the rendering, all looks good. Looks like the affected pages weren't optimized to begin with 🤦♂, so we're ok.
Thanks for fixing the duplication 🏅
Fixes brave/brave-browser#6832 and brave/brave-browser#6881.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
I added some borders in the existing files:
so that I could see red borders on:
brave://rewards
brave://welcome
brave://sync
and blue ones on:
brave://settings
brave://history
After my change, everything looked blue, as expected. I then applied a similar patch for the other font:
and looked for green borders instead of red, and yellow borders instead of blue.
After my patch, everything went yellow as expected, except for WebTorrent which doesn't use Poppins for some reason.
Finally, I also verified that I hadn't broken the following:
chrome://brave-resources/fonts/muli.css
chrome://brave-resources/fonts/poppins.css
Reviewer Checklist:
After-merge Checklist:
changes has landed on.