Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when Auto Contribute is disabled there is no way to set a Monthly Tip #7214

Closed
LaurenWags opened this issue Dec 4, 2019 · 4 comments · Fixed by brave/brave-core#4142
Closed

Comments

@LaurenWags
Copy link
Member

Description

When you toggle AC off, the section in the panel which contains the ability to access the Monthly Contribution banner is removed.

In previous versions (1.0.x and before), you set your monthly tip from the same banner as one-time tip. However, with #5996 we added the separate Monthly Contribution banner. Before, even if AC was off, you could still select the checkbox on the one time tip banner to set a monthly tip. Now you are unable to do this.

Steps to Reproduce

  1. Enable Rewards
  2. Visit a site (verified or not)
  3. View panel, see Monthly Contribution label and Set button.
  4. Toggle AC off.
  5. Visit a site.
  6. View panel.

Actual result:

No way to set a Monthly tip:
Screen Shot 2019-12-04 at 5 28 16 PM

Screen Shot 2019-12-04 at 5 38 45 PM

Expected result:

Probably should move the Monthly Contribution/Set button out of the section that gets removed when AC is toggled off.
Screen Shot 2019-12-04 at 5 28 00 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @alexwykoff @mandar-brave @ryanml

@LaurenWags
Copy link
Member Author

note - if you already have a monthly tip for a publisher set before disabling AC, this section does display in the panel:

Screen Shot 2019-12-04 at 6 55 36 PM

Screen Shot 2019-12-04 at 6 56 23 PM

@alexwykoff alexwykoff added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Dec 5, 2019
@alexwykoff
Copy link

@NejcZdovc consensus from product team is that this is P1

NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 5, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 5, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 5, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 5, 2019

Nice find @LaurenWags. Reproduced in Windows 10 x64 - 1.1.8

NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 6, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 6, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 6, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 19, 2019

Verified passed with

Brave 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
  • Verified able to update and remove monthly tips from panel when AC is off
  • Verified able to remove monthly tips from brave://rewards when AC is off

Screen Shot 2019-12-19 at 5 51 02 PM

Screen Shot 2019-12-19 at 5 51 15 PM

Screen Shot 2019-12-19 at 5 51 23 PM

Verification passed on

Brave 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS
  • Verified STR from description
  • Verified able to update and remove monthly tips from panel when AC is off
  • Verified able to remove monthly tips from brave://rewards when AC is off
  • Verified that the monthly contribution goes through when AC is off

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants