-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when Auto Contribute is disabled there is no way to set a Monthly Tip #7214
Labels
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
alexwykoff
added
the
priority/P1
A very extremely bad problem. We might push a hotfix for it.
label
Dec 5, 2019
@NejcZdovc consensus from product team is that this is P1 |
Nice find @LaurenWags. Reproduced in Windows 10 x64 - 1.1.8 |
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Dec 6, 2019
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Dec 6, 2019
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Dec 6, 2019
Verified passed with
Verification passed on
|
LaurenWags
added
QA Pass-macOS
release-notes/exclude
and removed
release-notes/include
labels
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
When you toggle AC off, the section in the panel which contains the ability to access the Monthly Contribution banner is removed.
In previous versions (1.0.x and before), you set your monthly tip from the same banner as one-time tip. However, with #5996 we added the separate Monthly Contribution banner. Before, even if AC was off, you could still select the checkbox on the one time tip banner to set a monthly tip. Now you are unable to do this.
Steps to Reproduce
Monthly Contribution
label andSet
button.Actual result:
No way to set a Monthly tip:
Expected result:
Probably should move the Monthly Contribution/Set button out of the section that gets removed when AC is toggled off.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @alexwykoff @mandar-brave @ryanml
The text was updated successfully, but these errors were encountered: