Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing closing brace in CSS for cosmetic style rules #7442

Closed
antonok-edm opened this issue Dec 17, 2019 · 1 comment
Closed

Missing closing brace in CSS for cosmetic style rules #7442

antonok-edm opened this issue Dec 17, 2019 · 1 comment
Assignees
Labels
closed/duplicate Issue has already been reported dev-concern

Comments

@antonok-edm
Copy link
Collaborator

The generateCosmeticBlockingStylesheet method appears to mistakenly omit a closing brace whenever custom style rules are added to a stylesheet that will be injected into a page.

Existing browser tests perform as expected -- it appears an implicit closing brace is added at the end of the stylesheet. Although custom style rules are uncommon within filter lists; if more than one were added, the stylesheet would become malformed.

The missing closing brace is located here. A unit test should be added to ensure generateCosmeticBlockingStylesheet builds correctly formatted stylesheets when one or more custom style rules are used.

@pes10k
Copy link
Contributor

pes10k commented Feb 14, 2020

@antonok-edm can this be closed?

@pes10k pes10k closed this as completed May 1, 2020
@antonok-edm antonok-edm added this to the Dupe / Invalid / Not actionable milestone May 29, 2020
@antonok-edm antonok-edm added the closed/duplicate Issue has already been reported label May 29, 2020
@antonok-edm antonok-edm removed this from the Dupe / Invalid / Not actionable milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported dev-concern
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants