Update generateCosmeticBlockingStylesheet implementation w/ tests #4246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7442.
I also took the chance to rename the
cosmeticFilterGenericExceptions
event tocosmeticFilteringEnabled
, since generic exceptions are no longer sent to the content script as per @bridiver's feedback on #3303.Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
New unit tests are added for
generateCosmeticBlockingStylesheet
to ensure the generated stylesheets are correctly formatted.Reviewer Checklist:
After-merge Checklist:
changes has landed on.