Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filtering crashes on Windows #8113

Closed
antonok-edm opened this issue Feb 7, 2020 · 6 comments · Fixed by brave/brave-core#4540
Closed

Cosmetic filtering crashes on Windows #8113

antonok-edm opened this issue Feb 7, 2020 · 6 comments · Fixed by brave/brave-core#4540

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Feb 7, 2020

Test plan

See brave/brave-core#4540

Description

As per this report #5381 (comment) and others, cosmetic filtering crashes the browser when enabled in a tab on Windows.

The crash traceback indicates an issue in adblock-rust-ffi.

@antonok-edm
Copy link
Collaborator Author

This adblock-rust-ffi PR should solve the issue when merged in brave-core.

@LaurenWags
Copy link
Member

@antonok-edm could you add a test plan for manual QA? if this doesn't need to be manually QA'd we can remove QA/Yes label and add QA/No. Thanks!

@antonok-edm
Copy link
Collaborator Author

@LaurenWags easy enough, updated the PR!

@LaurenWags
Copy link
Member

great, thanks @antonok-edm!

@bsclifton
Copy link
Member

bsclifton commented Mar 3, 2020

Fixed in 1.6 with brave/brave-core#4540
Fixed in 1.5 with brave/brave-core#4589

Updated test plan in brave/brave-core#4540 to be more specific and linked to it in the top post 😄

@GeetaSarvadnya
Copy link

Verification passed on

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment