Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting for conversion/attribution confirmation #8640

Closed
jsecretan opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4931
Closed

Remove setting for conversion/attribution confirmation #8640

jsecretan opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4931
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
1.5.x - Release

Comments

@jsecretan
Copy link

Description

Going through the conversion setting with users, it turns out this is very confusing and given the number of campaigns that will have this requirement, not a helpful distinction. We are going to remove this setting for now.
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Mar 11, 2020
@tmancey tmancey added the QA/Yes label Mar 11, 2020
@rebron rebron mentioned this issue Mar 12, 2020
Closed
4 tasks
This was referenced Mar 13, 2020
Merged
Merged
Merged
@tmancey tmancey added this to the 1.8.x - Nightly milestone Mar 16, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Mar 17, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.14.6 (Build 18G3020)
  • Confirmed setting removed from Ads Settings

Screen Shot 2020-03-17 at 11 21 16 AM

Verification passed on

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Verification passed on

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

image

tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #4932 from /issues/8640-1.7.x
0112680 
Removed setting for conversion/attribution confirmation - 1.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

Removed setting for conversion/attribution confirmation brave/brave-core
7 participants
@jsecretan @tmancey @kjozwiak @rebron @LaurenWags @btlechowski @GeetaSarvadnya