Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Google welcome page is not shown upon win10 first launch #87

Closed
srirambv opened this issue Mar 1, 2018 · 1 comment
Closed

Ensure Google welcome page is not shown upon win10 first launch #87

srirambv opened this issue Mar 1, 2018 · 1 comment
Assignees
@AlexeyBarabash
Labels
bug OS/Windows QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2018

Following google welcome pages are shown on first launch on Windows

URL : chrome://welcome-win10
image

URL: chrome://welcome
image

URL: chrome://welcome/?vairant=everywhere
image

cc: @bbondy
@srirambv srirambv added the bug label Mar 1, 2018
This was referenced Mar 1, 2018
Closed
Closed
@bbondy bbondy changed the title Ensure Google welcome page is not shown upon first launch Ensure Google welcome page is not shown upon win10 first launch Mar 5, 2018
bbondy referenced this issue in brave/brave-core Mar 5, 2018
@bbondy
Show Brave NewTab page for Win10
6da7ab1 
Fix https://github.com/brave/brave/issues/87
@bbondy bbondy mentioned this issue Mar 5, 2018
Merged
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #87 from brave/disable-extension
43a2daf 
Add switch for disable-brave-extension
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Sep 21, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified chrome://welcome-win10 navigates to chrome://welcome
  • Verified chrome://welcome/?varient=everywhere navigates to chrome://welcome

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
bug OS/Windows QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @kjozwiak @srirambv @AlexeyBarabash @btlechowski @GeetaSarvadnya