Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monthly statement drop down shows previous month in dropdown for current month #8836

Closed
LaurenWags opened this issue Mar 24, 2020 · 5 comments · Fixed by brave/brave-core#5071

Comments

@LaurenWags
Copy link
Member

Description

Monthly statement drop down shows February 2020 however data is being shown (right side summary and bottom lists) for current month of March.

Steps to Reproduce

  1. Clean profile w/ staging flags
  2. Enable Rewards, claim grant
  3. Make a one time tip
  4. Open monthly statement

Actual result:

Dropdown says 'February 2020' (note, this is the only option in the drop down) however data shown is for current month of March:
Screen Shot 2020-03-24 at 12 23 33 PM
Screen Shot 2020-03-24 at 12 20 37 PM

Expected result:

I expected the drop down to say 'March 2020' or 'current month' something like that.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @mandar-brave

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 24, 2020

Reproduces on Nightly

Brave 1.8.36 Chromium: 81.0.4044.69 (Official Build) nightly (64-bit)
Revision 6813546031a4bc83f717a2ef7cd4ac6ec1199132-refs/branch-heads/4044@{#776}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-03-24 at 2 22 30 PM

Screen Shot 2020-03-24 at 2 24 12 PM

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 24, 2020

from the spec (outdated):

Statement means ‘past tense’. For activities which have concluded. If users want insight into current status, the Rewards Settings page should be modified to accommodate.

based on the above, should the statement show current activity (in this case, data for March - tips, token grants accepted, etc)? Maybe the statement shouldn't be available as there isn't any data for previous month?

basically, what seems to be happening is if you select February, you see March's data. If you select January, you see February data:
Screen Shot 2020-03-24 at 3 27 00 PM

cc @mandar-brave for product insight

@NejcZdovc
Copy link
Contributor

@LaurenWags yes we decided to show current month as well, I think it's just selection problem (showing wrong month)

@LaurenWags
Copy link
Member Author

great, thanks for clarification @NejcZdovc 👍

@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 31, 2020

Verified passed with

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-03-31 at 10 10 33 AM

  • Verified that when you have multiple months, you can select a different month and the monthly statement is updated accordingly:

Screen Shot 2020-03-31 at 10 19 16 AM

Screen Shot 2020-03-31 at 10 19 03 AM

Screen Shot 2020-03-31 at 10 19 10 AM

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description
    image

Verification passed on

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment