Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Guest mode and add profile still available in drop drown menu after add policies into regedit #8907

Open
pc-v2 opened this issue Mar 29, 2020 · 8 comments
Labels
bug enterprise OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".

Comments

@pc-v2
Copy link

pc-v2 commented Mar 29, 2020

Description

Guest mode and add profile still available in drop drown menu after add policies into regedit

Steps to Reproduce

  1. open regedit
    1.a set guest mode and add profile to disable

  2. open brave browser drop down menu

  3. it still there

Actual result:

image
image
image

Expected result:

Guest mode and profile manager disabled

Reproduces how often:

Brave version (brave://version info)

`

Brave 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 2004 (Build 19041.172)
JavaScript V8 8.0.426.27
Flash (Disabled)
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36
Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,WebUIDarkMode,SimplifyHttpsIndicator --disable-features=AutofillServerCommunication,AllowPopupsDuringPageUnload,LookalikeUrlNavigationSuggestionsUI,AudioServiceOutOfProcess,SmsReceiver,NotificationTriggers,WebXrGamepadModule,VideoPlaybackQuality,WebXR --flag-switches-begin --load-media-router-component-extension=0 --flag-switches-end --enable-audio-service-sandbox --disable-webrtc-apm-in-audio-service --disable-sync
@pc-v2
Copy link
Author

pc-v2 commented Apr 14, 2020

is this fixed in latest version?

@bsclifton
Copy link
Member

@pc-v2 what is the path you're editing? Per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy it should be:
HKEY_LOCAL_MACHINE\Software\Policies\BraveSoftware\Brave

@pc-v2
Copy link
Author

pc-v2 commented Apr 14, 2020

@pc-v2 what is the path you're editing? Per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy it should be:
HKEY_LOCAL_MACHINE\Software\Policies\BraveSoftware\Brave

@pc-v2 what is the path you're editing? Per https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy it should be:
HKEY_LOCAL_MACHINE\Software\Policies\BraveSoftware\Brave

yes, i use that path already
image

@bsclifton
Copy link
Member

bsclifton commented Apr 14, 2020

@pc-v2 curious - what happens if you try to create another profile or open a guest profile? Knowing this will help judge severity of the issue (hopefully, it's still blocked but just shows in menu)

Definitely seems like we have a bug with those two. Can you confirm that the Private Window with Tor option is hidden? And also Incognito disabled as expected?

@bsclifton bsclifton added the bug label Apr 14, 2020
@pc-v2
Copy link
Author

pc-v2 commented Apr 15, 2020

@pc-v2 curious - what happens if you try to create another profile or open a guest profile? Knowing this will help judge severity of the issue (hopefully, it's still blocked but just shows in menu)

Definitely seems like we have a bug with those two. Can you confirm that the Private Window with Tor option is hidden? And also Incognito disabled as expected?

yes, tor and incognito is disabled as expected, but guest window and profile manager still able to access even i disable it (BrowserAddPersonEnabled)

@rebron rebron added enterprise priority/P4 Planned work. We expect to get to it "soon". labels May 22, 2020
@srirambv srirambv changed the title Guest mode and add profile still available in drop drown menu after add policies into regedit [Desktop] Guest mode and add profile still available in drop drown menu after add policies into regedit Sep 9, 2020
@vijay2977
Copy link

Any updates on this issue, guys this is an open gaping hole in disabling privacy mode.

@daweth
Copy link

daweth commented Jan 20, 2022

Any updates? this renders the registries completely useless

@gelatinbomb
Copy link

It is not only a Brave thing. It appears Vivaldi and Ungoogled Chromium struggles with this too.
This is really bad damn it
In my case the "BrowserGuestModeEnabled" works perfectly on both browsers. On the other side "BrowserAddPersonEnabled" is completely useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enterprise OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 Backlog
Development

No branches or pull requests

6 participants