-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Brave-specific options configurable through Windows Group Policy templates #26502
Comments
It is nice Brave implemented a policy for Up/Down Shields #25394 @bsclifton @mherrmann @spylogsster I think it would be good if Brave expanded even more Shields/Adblock policies to make Brave a really good browser for admins to control what they want the organizations to see within Brave and even for Parental Control. I see many people requesting a block site feature, and people talk about DNS and all that way of 'blocking' websites, but technically Brave can already do that, it only needs ways to stop anyone from bypassing them easily when they are not meant to. First, one important policy/feature would be to have a way for 'organization' to be able to set custom lists and rules that no user can delete or disable, just like how Windows Firewalls features and rules can be set through GPO. Second, and somehow a more important feature/flag/policy, it's to stop users from clicking the proceed button if/when a domain is blocked by the adblocker or change the warning screen to reflect it was blocked by a organization or something. You know, the little screen which is done by using Just adding these two policies will add a way for organizations, admins, parents, schools to easily restrict/block websites without having to deal with another feature and/or Brave Team having to implement a feature that is already done with the adblocker, because the feature is already there, it only needs ways to prevent users to proceed or disable the rules. Something important to note and why I say Brave already can block sites, it's that when Brave shows the warning screen, Brave hasn't connected to the Domain/IP, it shows the warning based on just on what the URL says before anything gets resolved. The website will only resolve and appear in DNS server logs or firewalls or anything when the user clicks the Proceed button, making it a great way (and already built) to block websites completely. If adblocker is used for this kind of stuff, not only it will be 'one feature less to build' by Brave Team, but also, no DNS server or VPN or anything else (but using another web browser) can bypass it for the way these document block works which is done only for what it is seen in the URL. Which means, (another good point about using Adblocker for 'website blocker' feature) is that it can be done in flexible ways. Example: You want to block
And if we count the fact that the adblocker has scriptlet injections like window-close-if or CSP features like sandbox that can prevent popups and stops downloads in whatever website, using CSP is not perfect since people can middle click and download the file that way, but it can prevent automatic downloads, to truly stop downloads, again, $document for the way it works by searching in the URL, would be able to stop the download, so a rule like I tried to find other issues with this type of request, so hope it is not duplicate, but hope this helps to understand how good these two policies can be. Thank you and have a good day!. |
The below setting also needs to be added, so that the VPN feature can be disabled across managed devices.
|
@DesertBear thanks for requesting that - I logged that one with #29397 and we can look at this soon 😄 |
Hiya, Cheers! |
While Link: Example:
|
Cc @AlanBreck . Can you update https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy? |
The support site is actually managed by @Brave-Matt, so I'm looping him in. |
|
@mherrmann - I'm not sure how much trouble it is to append to the But we could hardcode (at least for the moment) the following Brave specific values: Windows Registry Editor Version 5.00
; brave version: 124.1.67.42
[HKEY_LOCAL_MACHINE\Software\Policies\BraveSoftware\Brave]
"TorDisabled"=dword:00000001
"IPFSEnabled"=dword:00000000
"BraveRewardsDisabled"=dword:00000001
"BraveWalletDisabled"=dword:00000001
"BraveVPNDisabled"=dword:00000001
"BraveAIChatEnabled"=dword:00000000
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave\BraveShieldsEnabledForUrls]
"1"="[*.]twitter.com"
"2"="https://www.example.com"
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave\BraveShieldsDisabledForUrls]
"1"="https://www.example.com"
"2"="[*.]brave.com"
This should cover all the ones listed at https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy#h_01HE8CWCDW9FWDWB74VCGZZEMR Maybe you can point me in the right direction? |
@bsclifton sure. My previous work on the topic was brave/brave-core#16351, but it became obsolete before it was merged due to upstream changes. The policy templates are a GN target, |
@bsclifton I'm using these policies to disable Brave Wallet and Brave Rewards from the browser; I have two questions:
Thank you! |
This is an issue with all Chromium-based browsers. You will need to set the below policies to keep DNS-over-HTTPS enabled. Controls the mode of DNS-over-HTTPS:
Specify URI template of desired DNS-over-HTTPS resolver:
|
@DesertBear Thanks! :) |
Making some good progress here 😄 |
…uses. The assets generated now include all of the Brave group policies in a group called "BraveSoftware". Fixes brave/brave-browser#26502
…uses. The assets generated now include all of the Brave group policies in a group called "BraveSoftware". Fixes brave/brave-browser#26502
OK great - I have a working solution and we should be able to accept it soon 😄 Working with reviewers on the last few items For folks interested, you can check out brave/brave-core#25710 |
…uses. The assets generated now include all of the Brave group policies in a group called "BraveSoftware". Fixes brave/brave-browser#26502
…uses. The assets generated now include all of the Brave group policies in a group called "BraveSoftware". Fixes brave/brave-browser#26502
Verification
|
Removed |
Verification INPROGRESS on
|
@mherrmann: I am verifying the issue on Windows 10 x64 and Windows 11 x64. I have followed the test plan mentioned via #26502 (comment). On both win10 and win11, the issue is not working as expected. When the Tor/VPN is enabled via I have few questions reg the Group Policy template:
Unable to disable the Brave-specific browser options via Group Policy settings from India region. The same thing is working fine for @MadhaviSeelam on Windows 11 x64 Please see the recorded file below: https://drive.google.com/file/d/1mA7c-IUN0eBGukDMow8otXNbwC6d6dbO/view?usp=sharing |
@GeetaSarvadnya the feature was implemented by @bsclifton. I think he will know more about this than me. |
@GeetaSarvadnya the templates are localized for those countries/locales - but usable in any. Unfortunately, none of the Brave strings are being localized. Only the standard Chromium templates are actually localized. For testing, you can always pick the I watched the video - thanks for capturing @GeetaSarvadnya. The file you opened looks correct and you set it properly. We could look at the registry perhaps as a next step. Specifically, open I'm curious if any values are being shown here. The best way to check policies being set (besides registry) is via brave://policy which you already did check What version of Windows do you have? I'm curious if this is something like Pro edition lets someone do group policy but Home edition doesn't let you do group policy? 🤔 The actual UI worked fine for |
@bsclifton: When I enable/disable brave specific browser options (e.g VPN/Tor) via But, If I set policies via REGEDIT(Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\BraveSoftware\Brave) path, the policies are working as expected. When I open the browser, the browser options are disabled and also the policies are shown as |
Test plan (added by @bsclifton)
gpedit.msc
, hit enterComputer Configuration
, right clickAdministrative Templates
Add/Remove Templates...
policy_templates.zip
and back ingpedit.msc
, clickAdd...
windows\adm\en-US\brave.adm
fileOpen
Classic Administrative Templates
. In theBrave Software
folder, you'll see the actual policies.Managed by your organization
in the hamburger menu.Original issue description
This is a follow-up to #26501. There, we provide templates for changing general browser settings. The goal of this present issue is to build on that work and make it possible to configure Brave-specific browser options via Group Policy settings. Per the current documentation, the minimal settings that should be supported are:
Related:
The text was updated successfully, but these errors were encountered: