Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Cookie banner blocker #8974

Closed
anthonypkeane opened this issue Apr 1, 2020 · 5 comments · Fixed by brave/brave-core#15063
Closed

[Android] Cookie banner blocker #8974

anthonypkeane opened this issue Apr 1, 2020 · 5 comments · Fixed by brave/brave-core#15063
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields The overall Shields feature in Brave. feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description

Linked to #5318

Please implement a cookie banner blocker on Android

cc @jamesmudgett or @karenkliu for design

@anthonypkeane anthonypkeane added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes feature-request OS/Android Fixes related to Android browser functionality labels Apr 1, 2020
@DragoCubed
Copy link

related to #9338

@kjozwiak
Copy link
Member

The above requires 1.45.104 or higher for 1.45.x verification 👍

@kjozwiak
Copy link
Member

Labelling as QA/Blocked as we'll need to wait for #26078 to be fixed and uplifted into 1.45.x. We'll also need to enable BraveAdblockCookieListOptInStudy on BETA and Release before we can verify the above as we'll be enabling this feature via Grffin on both Desktop & Android.

@Uni-verse @srirambv I can run through this as I have the most context/been working on this for a while.

@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.45.111 Chromium: 107.0.5304.62 (Official Build) (32-bit)
--- | ---
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Android 12; Build/SP1A.210812.016
  • enabled the feature via brave://flags#brave-adblock-cookie-list-opt-in
  • ensured that the cookie consent panel/notification appears after 5 refresh/loads
    • ensured that the cookie consent panel/notification appears when refreshing the same page five times
    • ensured that the cookie consent panel/notification appears when loading five different websites in new tabs
  • ensured that clicking/tapping on Block cookie notices enables the feature and dismisses the panel/notification
Example Example Example Example
Screenshot_20221024-091505_Brave Screenshot_20221024-092615_Brave Screenshot_20221024-092629_Brave Screenshot_20221024-092058_Brave
  • ensured that clicking/tapping on No thanks doesn't enable the feature and dismisses the panel/notification
Example Example Example
Screenshot_20221024-093213_Brave Screenshot_20221024-093539_Brave Screenshot_20221024-093559_Brave
  • ensured that you can scroll through a website without the cookie consent panel/notification dismissing
  • ensured that tapping outside of the panel/notification didn't dismiss the panel/notification
  • ensured that the cookie consent panel/notification is dismissed whem:
    • ensured panel/notification is being dismissed when opening a new tab
    • ensured panel/notification is being dismissed when closing active tab (where cookie consent panel is visible
    • ensured panel/notification is being dismissed when switching tabs
  • ensured that enabling the feature via Block cookie consent notices settings works as expected if No, thanks was selected
  • ensured that once dismissed, the cookie consent panel/notification doesn't appear again

@kjozwiak
Copy link
Member

kjozwiak commented Oct 24, 2022

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.45.111 Chromium: 107.0.5304.62 (Official Build) (32-bit)
--- | ---
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Android 12; Build/SP2A.220305.013
  • enabled the feature via brave://flags#brave-adblock-cookie-list-opt-in
  • ensured that the cookie consent panel/notification appears after 5 refresh/loads
    • ensured that the cookie consent panel/notification appears when refreshing the same page five times
    • ensured that the cookie consent panel/notification appears when loading five different websites in new tabs
  • ensured that clicking/tapping on Block cookie notices enables the feature and dismisses the panel/notification
Example Example Example Example
Screenshot_20221024_095829_Brave Screenshot_20221024_095910_Brave Screenshot_20221024_095848_Brave Screenshot_20221024_095944_Brave
  • ensured that clicking/tapping on No thanks doesn't enable the feature and dismisses the panel/notification
Example Example Example
Screenshot_20221024_100454_Brave Screenshot_20221024_100443_Brave Screenshot_20221024_100519_Brave
  • ensured that you can scroll through a website without the cookie consent panel/notification dismissing
  • ensured that tapping outside of the panel/notification didn't dismiss the panel/notification
  • ensured that the cookie consent panel/notification is dismissed whem:
    • ensured panel/notification is being dismissed when opening a new tab
    • ensured panel/notification is being dismissed when closing active tab (where cookie consent panel is visible
    • ensured panel/notification is being dismissed when switching tabs
  • ensured that enabling the feature via Block cookie consent notices settings works as expected if No, thanks was selected
  • ensured that once dismissed, the cookie consent panel/notification doesn't appear again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/shields The overall Shields feature in Brave. feature-request OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants