Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie consent modal/notification should close when switching/losing or opening NTP #26078

Closed
kjozwiak opened this issue Oct 17, 2022 · 2 comments · Fixed by brave/brave-core#15517
Assignees
Labels
feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

Description

As per the desktop implementation of the Cookie Consent feature, we should ensure that it dismisses/closes in the following cases:

* The user switches tabs
* The user closes the active tab
* The user opens a new tab

Once #25811 was fixed, it made it so the user couldn't dismiss the notification/modal without making a decision but didn't take the above cases into consideration. As per @pes10k, we should get this into 1.45.x so when we enable the BraveAdblockCookieListOptInStudy, it will work as expected on 1.45.x.

Steps to reproduce

  1. download/install Brave Nightly
  2. open any random website
  3. refresh the same website ~5 times (the cookie consent should appear after the 5th refresh)
  4. once it's visible, don't make a decision and start creating new tabs/switching tabs

You'll notice that the cookie consent notification/modal isn't being dismissed.

Actual result

Example Example
Screenshot_20221015-230339_Brave - Nightly Screenshot_20221015-230352_Brave - Nightly

Expected result

The cookie consent notification/modal should be dismissed in the following cases:

* The user switches tabs
* The user closes the active tab
* The user opens a new tab

Issue reproduces how often

100% reproducible when using the STR/Cases outlined above.

Version/Channel Information:

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+ (Phone)
  • Android version: Android 13

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @pes10k @deeppandya @timchilds

@kjozwiak
Copy link
Member Author

The above requires 1.45.109 or higher for 1.45.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 21, 2022

Verification PASSED on vivo x70 Pro version 12 running Bravemonoarm64.1pk_1.45.109

  • ensured that the cookie consent panel/notification is dismissed when a user switches tabs
  • ensured that the cookie consent panel/notification is dismissed when a user user closes the active tab
  • ensured that the cookie consent panel/notification is dismissed when a user user opens a new tab
Example Example
Screenshot_20221021_170550 Screenshot_20221021_170624

Verification PASSED on Samsung Galaxy tab A7 version 12 running Bravemonoarm64.1pk_1.45.109

  • ensured that the cookie consent panel/notification is dismissed when a user switches tabs
  • ensured that the cookie consent panel/notification is dismissed when a user user closes the active tab
  • ensured that the cookie consent panel/notification is dismissed when a user user opens a new tab
Example Example
Screenshot_20221021-171251_Brave Screenshot_20221021-171336_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants