Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] DuckDuckGo toggle does not reflect as changed when toggled in guest window #9525

Closed
simonhong opened this issue Apr 29, 2020 · 1 comment · Fixed by brave/brave-core#5414
Closed

[Desktop] DuckDuckGo toggle does not reflect as changed when toggled in guest window #9525

simonhong opened this issue Apr 29, 2020 · 1 comment · Fixed by brave/brave-core#5414
Assignees
@simonhong
Labels
feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@simonhong
Copy link
Member

STR:

  1. Open Guest window
  2. Click DDG button
  3. DDG button should be toggled but it's not changed. But search provider is properly set.
@simonhong simonhong added this to the 1.10.x - Nightly milestone Apr 29, 2020
@simonhong simonhong self-assigned this Apr 29, 2020
@simonhong simonhong mentioned this issue Apr 29, 2020
Merged
32 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 6, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 19, 2020 •
edited by LaurenWags
Loading

Verification passed on


Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.30)

Verified passed with

Brave | 1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-06-24 at 11 26 33 AM

Verified passed with

Brave	1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

@rebron rebron changed the title DDG toggle button is not updated in guest window [Desktop] DuckDuckGo toggle does not reflect as changed when toggled in guest window Jul 14, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix DDG button state is not updated in guest window brave/brave-core
5 participants
@bsclifton @rebron @simonhong @LaurenWags @GeetaSarvadnya