Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DDG button state is not updated in guest window #5414

Merged
merged 1 commit into from
May 18, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 29, 2020

guest profile and its otr profile's type is GUEST_PROFILE not INCOGNITO_PROFILE.
Because of this, NTP handler of Guest window doesn't monitor kUseAlternativeSearchEngineProvider so far.

Resolves brave/brave-browser#9525

Submitter Checklist:

Test Plan:

  1. Open Guest window
  2. Click DDG button
  3. Check DDG Button is toggled properly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.10.x - Nightly milestone Apr 29, 2020
@simonhong simonhong requested review from petemill and bsclifton April 29, 2020 06:51
@simonhong simonhong self-assigned this Apr 29, 2020
@simonhong
Copy link
Member Author

Unrelated BraveRewardsBrowserTest.NotVerifiedWallet was failed.
and android unittest was failed but I think it's expected now.

@NejcZdovc NejcZdovc removed this from the 1.10.x - Beta milestone May 15, 2020
@simonhong simonhong added this to the 1.11.x - Nightly milestone May 15, 2020
So far, NTP handler of Guest window doesn't monitor kUseAlternativeSearchEngineProvider.
@bsclifton bsclifton force-pushed the fix_guest_window_ddg_button branch from 65e368b to 03a76ad Compare May 18, 2020 18:41
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great and also works great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] DuckDuckGo toggle does not reflect as changed when toggled in guest window
3 participants