-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display sidebar navigation for Settings page #958
Comments
Stashing so I can check out another issue
Making good progress here; for those interested, here are the branches to check out: |
Stashing so I can check out another issue
Stashing so I can check out another issue
Making good progress :) - `Settings` header added over primary items (and restyled `Advanced` to match) - Padding and margin appear to match spec - Specified different font; page needs to be wired to properly include it - Sidebar has white background + borders with radius - Colors: - active items use `brandBrave` orange and bold the text - header incidently is now orange also - inactive items use `subtleInteracting` - `About Brave` text uses `subtle` - Product version (ex: 0.55.2) shown under `About Brave` along with a default icon - `Extensions` moved up under `Settings` - `Appearance` moved to last item before `Advanced`
Making good progress :) - `Settings` header added over primary items (and restyled `Advanced` to match) - Padding and margin appear to match spec - Specified different font; page needs to be wired to properly include it - Sidebar has white background + borders with radius - Colors: - active items use `brandBrave` orange and bold the text - header incidently is now orange also - inactive items use `subtleInteracting` - `About Brave` text uses `subtle` - Product version (ex: 0.55.2) shown under `About Brave` along with a default icon - `Extensions` moved up under `Settings` - `Appearance` moved to last item before `Advanced`
@rossmoody @bradleyrichter putting 'extensions' as an item in this sidebar makes me uncomfortable since it opens a new page that doesn't have the sidebar, as opposed to every other item, the behavior of which is to scroll the page to the item's section. Should Extensions actually be on the header nav? |
@petemill the Extensions link in the sidebar should link to the Extensions section in settings where a user can then go to a new page. Same behavior as with Sync right below it. Extensions is an item in the sidebar menu for Chrome that points to the external extensions manager page and not in settings. There are very few access points for Extensions/Extensions manager. Possibly cleaner to have 'Extensions' in the upper nav but we're running out of real estate up there. |
Making good progress :) - `Settings` header added over primary items (and restyled `Advanced` to match) - Padding and margin appear to match spec - Specified different font; page needs to be wired to properly include it - Sidebar has white background + borders with radius - Colors: - active items use `brandBrave` orange and bold the text - header incidently is now orange also - inactive items use `subtleInteracting` - `About Brave` text uses `subtle` - Product version (ex: 0.55.2) shown under `About Brave` along with a default icon - `Extensions` moved up under `Settings` - `Appearance` moved to last item before `Advanced`
Verification passed on
Verification passed on
Verification PASSED on
|
Test plan
Description
Use persistent sidebar navigation in Settings
and Extensions page.chrome://settings
chrome://extensions(edit by petemill: extensions can be a follow-up, several things to discuss - #3771)See mock for appearance, order, styling.
Should be:
Clicking on links above will take you to the corresponding section on the main screen.
Default collapse -> Additional Settings section.
In order should be:
Show Brave logo and About Brave version.
Design
The text was updated successfully, but these errors were encountered: