Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield settings are not saved after restart browser #96

Closed
yrliou opened this issue Mar 14, 2018 · 4 comments
Closed

Shield settings are not saved after restart browser #96

yrliou opened this issue Mar 14, 2018 · 4 comments

Comments

@yrliou
Copy link
Member

yrliou commented Mar 14, 2018

STR:

  1. Open any page and set its shield setting
  2. Restart the browser

expected result: the setting is the same as the setting before restarting the browser
actual result: its shield setting is the same as our default shield setting, not the saved one

@yrliou yrliou added bug feature/shields The overall Shields feature in Brave. labels Mar 14, 2018
@yrliou yrliou self-assigned this Mar 14, 2018
@srirambv
Copy link
Contributor

Possible duplicate of #52?

@yrliou
Copy link
Member Author

yrliou commented Mar 14, 2018

@srirambv #52 is because fingerprinting protection & block phishing aren't actually implemented but just a UI stub, this issue is opened for all shield settings and focused on restoring saved settings after browser restart.
Fixing #11 (which PRs are currently under review) will solve the fingerprinting protection part of #52.

@srirambv
Copy link
Contributor

Sounds good 👍

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants