Call ContentSettingsService::OnExtensionPrefsLoaded when adding component extensions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
restore_extension_content_settings
branch
4 times, most recently
from
9ed54a8 to
087443e
Compare
yrliou
force-pushed
the
restore_extension_content_settings
branch
from
087443e to
c28967d
Compare
|
Reduce patching into chromium code directly by making subclasses per @bbondy's suggestion. |
bbondy
approved these changes
Mar 23, 2018
|
Much cleaner, thanks. 🎉 We just need to fixup |
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
set proper TARGET_GEN_DIR for dev builds
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Add more support for transpiling CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing brave/brave#96.
Summary of changes:
Although we ensure an entry of ContentSettingsStore will be registered for component extensions when fixing brave/brave#81, content settings are not restored after restart since ContentSettingsService::OnExtensionPrefsLoaded wasn't triggered to populate the values into content setting store. This patch triggers it which leads to a call into ContentSettingsStore::SetExtensionContentSettingFromList to populate the values.
Revise chromium's implementation of SetExtensionContentSettingFromList by delaying the content setting changed notification after all values in the list have been set. Before this change, I could only see the first entry from the list being saved into content setting store.
If there's a cleaner way to fix this, please feel free to suggest, thanks.