Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the switch for prediction service in the address bar in settings page #992

Closed
yrliou opened this issue Sep 6, 2018 · 1 comment · Fixed by brave/brave-core#429
Closed

Expose the switch for prediction service in the address bar in settings page #992

yrliou opened this issue Sep 6, 2018 · 1 comment · Fixed by brave/brave-core#429
Assignees
@bbondy
Labels
feature/search QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@yrliou
Copy link
Member

yrliou commented Sep 6, 2018 •
edited by srirambv
Loading

Test Plan

  • Ensure the following setting is listed under privacy
    image

Ref: https://github.com/brave/brave-core/pull/244/files#diff-0f4a33a4998a356ad68d5e8a2a5c78c1R44
@bsclifton bsclifton self-assigned this Sep 6, 2018
@bsclifton bsclifton added this to the Releasable builds 0.55.x milestone Sep 6, 2018
bbondy added a commit to brave/brave-core that referenced this issue Sep 10, 2018
@bbondy
Allow changing search suggestions (prediction service)
b6a8f49 
Fix brave/brave-browser#992
@bbondy bbondy assigned bbondy and unassigned bsclifton Sep 10, 2018
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@bbondy bbondy mentioned this issue Sep 10, 2018
Merged
11 tasks
@srirambv
Copy link
Contributor

srirambv commented Sep 25, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/search QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Allow changing search suggestions (prediction service) brave/brave-core
6 participants
@bbondy @yrliou @bsclifton @srirambv @LaurenWags @btlechowski