Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89.0.4389.90 to Chromium 89.0.4389.105 (1.23.x). #14897

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

mkarolin
Copy link
Contributor

Fixes #14891
Related PR: brave/brave-core#8331
Uplift from #14892

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade from Chromium 89.0.4389.90 to Chromium 89.0.4389.105
@kjozwiak
Copy link
Member

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-macos/2/execution/node/255/log/ & https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-macos/2/execution/node/258/log/. However, these are known failures that are not specific to this PR.

16:53:50  5 tests crashed:
16:53:50      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
16:53:50      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
16:53:50      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
16:53:50      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
16:53:50      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

post-init failed audit_deps as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-post-init/2/execution/node/145/log/. However, this is a known failure not specific to this PR.

Restarting Linux due to https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-linux/2/execution/node/73/log/.

@kjozwiak
Copy link
Member

Looks like the following test crashed via test-browser on Linux as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-linux/4/execution/node/255/log/ & https://ci.brave.com/job/pr-brave-browser-89.0.4389.105-1.23.x-linux/4/execution/node/258/log/.

00:17:27  6 tests crashed:
00:17:27      BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion068WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1000)
00:17:27      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
00:17:27      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
00:17:27      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
00:17:27      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
00:17:27      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

The above are all known other than the following:

BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion068WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled

However, the above crash didn't occur in the previous runs so we should be fine.

@kjozwiak kjozwiak added this to the 1.23.x - Beta milestone Mar 24, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 7c5223b into 1.23.x Mar 24, 2021
@kjozwiak kjozwiak deleted the 89.0.4389.105-1.23.x branch March 24, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants