Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89.0.4389.105 to Chromium 89.0.4389.114 (1.22.x). #15035

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

mkarolin
Copy link
Contributor

Fixes #15030
Related PR: brave/brave-core#8398
Uplift from #15031

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade from Chromium 89.0.4389.105 to Chromium 89.0.4389.114
@kjozwiak
Copy link
Member

post-init failed due to audit_deps failing as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.114-1.22.x-post-init/2/execution/node/145/log/. However, this is a known warning that's not related to this specific PR and doesn't block uplift.

macOS failed test-browser due to BraveNavigatorUserAgentFarblingBrowserTest.FarbleNavigatorUserAgent as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.114-1.22.x-macos/2/execution/node/255/log/ & https://ci.brave.com/job/pr-brave-browser-89.0.4389.114-1.22.x-macos/2/execution/node/258/log/. However, this is a known failure as per #13948 and doesn't block uplift.

03:58:22  1 test failed:
03:58:22      BraveNavigatorUserAgentFarblingBrowserTest.FarbleNavigatorUserAgent (../../brave/browser/farbling/brave_navigator_useragent_farbling_browsertest.cc:138)

@kjozwiak kjozwiak added this to the 1.22.x - Release #5 milestone Mar 31, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 2a307b8 into 1.22.x Mar 31, 2021
@kjozwiak kjozwiak deleted the 89.0.4389.114-1.22.x branch March 31, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants