Provide a script to do GRD string upgrades for Chromium rebasing #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #364 This replaces the following steps in the Brave wiki with a single command `npm run chromium_rebase_l10n`: --- Chromium rebase wiki steps getting replaced: ``` cd brave cp ../chrome/app/chromium_strings.grd app/brave_strings.grd ``` Open up `app/brave_strings.grd` and replace `settings_chromium_strings.grdp` with `settings_brave_strings.grdp` Also apply these replacements: ``` %s/Google Chrome/Brave/g %s/Chromium/Brave/g %s/Chrome/Brave/g %s/Google/Brave/g %s/The Brave Authors. All rights reserved./Brave Software Inc. All rights reserved./g %s/The Brave Authors/Brave Software Inc./g ``` `cp ../chrome/app/settings_chromium_strings.grdp app/settings_brave_strings.grdp` Open up the file and apply these replacements: ``` %s/Google Chrome/Brave/g %s/Chromium/Brave/g %s/Chrome/Brave/g %s/Google/Brave/g ``` `cp ../components/components_chromium_strings.grd ./app/components_brave_strings.grd` Open up the file and apply these replacements: ``` %s/Google Chrome/Brave/g %s/Chromium/Brave/g %s/Chrome/Brave/g %s/Google/Brave/g ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #364
This replaces the following steps in the Brave wiki with a single command
npm run chromium_rebase_l10n:Chromium rebase wiki steps getting replaced:
Open up
app/brave_strings.grdand replacesettings_chromium_strings.grdpwithsettings_brave_strings.grdpAlso apply these replacements:
cp ../chrome/app/settings_chromium_strings.grdp app/settings_brave_strings.grdpOpen up the file and apply these replacements:
cp ../components/components_chromium_strings.grd ./app/components_brave_strings.grdOpen up the file and apply these replacements:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: