Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade Chromium from 73.0.3683.75 to Chromium 74.0.3729.6 #3768

Closed
wants to merge 3 commits into from
Closed

WIP: Upgrade Chromium from 73.0.3683.75 to Chromium 74.0.3729.6 #3768

wants to merge 3 commits into from

Conversation

mkarolin
Copy link
Contributor

Fix #3502
Related PR: #1954

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

See #3502.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@mkarolin mkarolin added this to the 0.64.x - Nightly milestone Mar 18, 2019
@mkarolin mkarolin self-assigned this Mar 18, 2019
@mkarolin mkarolin mentioned this pull request Mar 18, 2019
Closed
19 tasks
@mkarolin
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.6
781894b
@mkarolin
Updated l10nUtil: nux_strings.grpd was moved.
4a60cb0 
Moved to onboarding_welcome_strings.grdp.

Chromium change:

commit 395516be219e7d31767e0ba47a5ac5c9f510c1ff
Author: Scott Chen <scottchen@chromium.org>
Date:   Tue Oct 23 00:05:48 2018 +0000

    NUX Onboarding: add some strings

    Replacing placeholder strings, and move all the add-string calls to under
    one function.

    also fixes a path bug for apps/ -> google_apps/ introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/1285210

    Bug: 874122
@mkarolin
Temporary set brave-core to 74.0.3729.6 branch
98c1be0
@mkarolin
Copy link
Contributor Author

Closing in lieu of #3790

@mkarolin mkarolin closed this Mar 19, 2019
@mkarolin mkarolin deleted the 74.0.3729.6 branch March 19, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
1 participant
@mkarolin