Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite chromium theme/x/common directory for avatar placeholder #5743

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Aug 20, 2019

This is now neccessary for brave/brave-core#3165 since it uses a simple method for replacing the chromium avatar placeholder: just overwriting the image.

Address #5207

This can be merged ahead of time with no consequence

Submitter Checklist:

Test Plan:

Contained within brave-core PR

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill merged commit a998b92 into master Aug 22, 2019
@petemill petemill deleted the profile-icons branch August 22, 2019 17:21
@petemill petemill added this to the 0.71.x - Nightly milestone Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants