Skip to content

Commit

Permalink
Enable about credits generation (#25673)
Browse files Browse the repository at this point in the history
The whole about credit process validation has now been guarded behind a
flag in upstream code, which only gets enabled in official builds. This
has allowed broken PRs to get through master. This change enables the gn
value for all builds, so breakage can be detected as early as possible.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/05db21cd6bc1decb3e90ca5eb152d7cea3bae19c

commit 05db21cd6bc1decb3e90ca5eb152d7cea3bae19c
Author: Fumitoshi Ukai <ukai@google.com>
Date:   Fri Aug 2 03:01:45 2024 +0000

    add gn arg `generate_about_credits`

    licenses.py is too slow on cog.
    allow disable about:credits generation.

    Bug: 355567690
  • Loading branch information
cdesouza-chromium committed Sep 20, 2024
1 parent a8c6459 commit 36ceeea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build/commands/lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ Config.prototype.buildArgs = function () {
brave_services_key_id: this.brave_services_key_id,
service_key_aichat: this.service_key_aichat,
service_key_stt: this.service_key_stt,
generate_about_credits: true,
}

if (!this.isBraveReleaseBuild()) {
Expand Down

0 comments on commit 36ceeea

Please sign in to comment.