Skip to content

Commit

Permalink
Merge pull request #1993 from brave/pr1992_fix-uplift-script_0.63.x
Browse files Browse the repository at this point in the history
Fix two bugs with uplift script (uplift to 0.63.x)
  • Loading branch information
bsclifton authored Mar 18, 2019
2 parents 41991e5 + 996e1bc commit 3aa51f3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion script/uplift.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def create_branch(channel, top_level_base, remote_base, local_branch):
if is_nightly(channel):
return local_branch

channel_branch = remote_base + '_' + local_branch
channel_branch = local_branch + '_' + remote_base

if is_sha(top_level_base):
compare_from = top_level_base
Expand Down Expand Up @@ -358,6 +358,7 @@ def create_branch(channel, top_level_base, remote_base, local_branch):
# create the branch
print('(' + channel + ') creating "' + channel_branch + '" from ' + remote_base)
execute(['git', 'checkout', remote_base])
execute(['git', 'pull', 'origin', remote_base])
execute(['git', 'checkout', '-b', channel_branch])

# TODO: handle errors thrown by cherry-pick
Expand Down

0 comments on commit 3aa51f3

Please sign in to comment.