Move SidebarItem instead of copying

issue: brave/brave-browser#25383 f/u PR for https://github.com/brave/brave-core/pull/15252/files#r983217073
brave · Oct 3, 2022 · 4b8cff4 · 4b8cff4
1 parent 4a04170
commit 4b8cff4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/components/sidebar/sidebar_item.cc b/components/sidebar/sidebar_item.cc
@@ -32,6 +32,10 @@ SidebarItem SidebarItem::Create(const GURL& url,
 }
 
 SidebarItem::SidebarItem() = default;
+SidebarItem::SidebarItem(const SidebarItem&) = default;
+SidebarItem& SidebarItem::operator=(const SidebarItem&) = default;
+SidebarItem::SidebarItem(SidebarItem&&) = default;
+SidebarItem& SidebarItem::operator=(SidebarItem&&) = default;
 
 SidebarItem::~SidebarItem() = default;
 

diff --git a/components/sidebar/sidebar_item.h b/components/sidebar/sidebar_item.h
@@ -42,6 +42,10 @@ struct SidebarItem {
                             bool open_in_panel);
 
   SidebarItem();
+  SidebarItem(const SidebarItem&);
+  SidebarItem& operator=(const SidebarItem&);
+  SidebarItem(SidebarItem&&);
+  SidebarItem& operator=(SidebarItem&&);
   ~SidebarItem();
 
   bool operator==(const SidebarItem& item) const;

diff --git a/components/sidebar/sidebar_service.cc b/components/sidebar/sidebar_service.cc
@@ -545,7 +545,7 @@ std::vector<SidebarItem> SidebarService::GetDefaultSidebarItems() const {
   for (const auto& item_type : SidebarService::kDefaultBuiltInItemTypes) {
     if (auto item = GetBuiltInItemForType(item_type);
         item.built_in_item_type != SidebarItem::BuiltInItemType::kNone) {
-      items.push_back(item);
+      items.push_back(std::move(item));
     }
   }
   return items;