Skip to content

Commit

Permalink
Merge pull request #2634 from brave/brave_channel_id_macos
Browse files Browse the repository at this point in the history
Use different key name for brave channel name in MacOS
  • Loading branch information
simonhong authored Jun 7, 2019
2 parents f60a2d8 + cd0ed86 commit 4def137
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/mac/tweak_info_plist.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def Main(argv):
output_path = options.plist_output

if options.brave_channel:
plist['KSChannelID'] = options.brave_channel
plist['BraveChannelID'] = options.brave_channel

plist['CrProductDirName'] = options.brave_product_dir_name

Expand Down
2 changes: 1 addition & 1 deletion chromium_src/chrome/common/channel_info_mac.mm
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// Keystone keys don't live in the framework.
NSBundle* bundle = base::mac::OuterBundle();

NSString* channel = [bundle objectForInfoDictionaryKey:@"KSChannelID"];
NSString* channel = [bundle objectForInfoDictionaryKey:@"BraveChannelID"];

// Only ever return "", "unknown", "beta", "dev", or "nightly" in an official
// build.
Expand Down

0 comments on commit 4def137

Please sign in to comment.