Removed disabling of SharedArrayBuffer feature.

This feature was disabled by brave/brave-browser#1051 to mitigate Spectre. Spectre was later addressed by Chromium via site isolation and Chromium re-enabled SharedArrayBuffer, but Brave didn't. Now in C74, WebAssemblyThreads feature is being enabled by default. Since WebAssemblyThreads is built with and auto-enables SharedArrayBuffer, there is no reason for us to continue keeping SharedArrayBuffer disabled. Aslo, removed a browser test for checking that SharedArrayBuffer is disabled. Chromium change making WebAssemblyThreads enabled by default: commit f9cc6b912e601070728b449892097cec0d59cbfa Author: Ben Smith <binji@chromium.org> Date: Wed Feb 27 02:09:43 2019 +0000 [wasm] Enable wasm threads by default See intent to ship blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU Bug: chromium:754910
brave · Mar 19, 2019 · 5a3fa98 · 5a3fa98
1 parent 5ff82b2
commit 5a3fa98
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 61 deletions.
diff --git a/app/brave_main_delegate.cc b/app/brave_main_delegate.cc
@@ -145,7 +145,6 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
       autofill::features::kAutofillServerCommunication.name,
       features::kAudioServiceOutOfProcess.name,
       features::kDefaultEnableOopRasterization.name,
-      features::kSharedArrayBuffer.name,
       unified_consent::kUnifiedConsent.name,
   };
 

diff --git a/app/sharedarraybuffer_disabledtest.cc b/app/sharedarraybuffer_disabledtest.cc
diff --git a/test/BUILD.gn b/test/BUILD.gn
@@ -279,7 +279,6 @@ static_library("browser_tests_runner") {
 test("brave_browser_tests") {
   sources = [
     "//brave/app/brave_main_delegate_browsertest.cc",
-    "//brave/app/sharedarraybuffer_disabledtest.cc",
     "//brave/browser/autocomplete/brave_autocomplete_provider_client_browsertest.cc",
     "//brave/browser/brave_scheme_load_browsertest.cc",
     "//brave/chromium_src/chrome/browser/google/chrome_google_url_tracker_client_browsertest.cc",