Fix 8163: Notification asking to set Brave as the default browser is …

…still shown after an external link opened via the 3P app (brave/brave-ios#8186)

Sources/Brave/Frontend/Browser/BrowserViewController.swift

@@ -890,15 +890,9 @@ public class BrowserViewController: UIViewController {
     // Schedule Default Browser Local Notification
     // If notification is not already scheduled or
     // an external URL opened in Brave (which indicates Brave is set as default)
-    if !Preferences.DefaultBrowserIntro.defaultBrowserNotificationScheduled.value,
-        Preferences.DefaultBrowserIntro.defaultBrowserNotificationShouldBeShown.value {
+    if !Preferences.DefaultBrowserIntro.defaultBrowserNotificationScheduled.value {
       scheduleDefaultBrowserNotification()
     }
-
-    // Remove pending notification if default browser is already set
-    if !Preferences.DefaultBrowserIntro.defaultBrowserNotificationShouldBeShown.value {
-      cancelScheduleDefaultBrowserNotification()
-    }
 
     privateModeCancellable = privateBrowsingManager
       .$isPrivateBrowsing
@@ -988,6 +982,8 @@ public class BrowserViewController: UIViewController {
   private func cancelScheduleDefaultBrowserNotification() {
     let center = UNUserNotificationCenter.current()
     center.removePendingNotificationRequests(withIdentifiers: [Self.defaultBrowserNotificationId])
+
+    Preferences.DefaultBrowserIntro.defaultBrowserNotificationIsCanceled.value = true
   }
 
   private func executeAfterSetup(_ block: @escaping () -> Void) {
@@ -3229,7 +3225,13 @@ extension BrowserViewController {
     if case .url(let navigatedURL, _) = path {
       if navigatedURL?.isWebPage(includeDataURIs: false) == true {
         Preferences.General.defaultBrowserCalloutDismissed.value = true
-        Preferences.DefaultBrowserIntro.defaultBrowserNotificationShouldBeShown.value = false
+        Preferences.DefaultBrowserIntro.defaultBrowserNotificationScheduled.value = true
+
+        // Remove pending notification if default browser is set brave
+        // Recognized by external link is open
+        if !Preferences.DefaultBrowserIntro.defaultBrowserNotificationIsCanceled.value {
+          cancelScheduleDefaultBrowserNotification()
+        }
       }
     }
 

Sources/Onboarding/OnboardingPreferences.swift

@@ -90,8 +90,8 @@ extension Preferences {
       default: false)
 
     /// Whether a default browser local notification should be shown
-    public static let defaultBrowserNotificationShouldBeShown = Option<Bool>(
-      key: "general.default-browser-notification-shown",
-      default: true)
+    public static let defaultBrowserNotificationIsCanceled = Option<Bool>(
+      key: "general.default-browser-notification-canceled",
+      default: false)
   }
 }