rename shields string variable

brave · Mar 2, 2020 · 8667715 · 8667715
1 parent eeca051
commit 8667715
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html b/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html
@@ -130,7 +130,7 @@
       </select>
     </div>
     <div class="settings-box">
-      <div class="label shields-primary-title">$i18n{lookFeelTitle}</div>
+      <div class="label shields-primary-title">$i18n{shieldsLookFeelTitle}</div>
     </div>
     <settings-toggle-button
         class="continuation"

diff --git a/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc b/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
@@ -99,7 +99,7 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
       IDS_SETTINGS_BRAVE_SHIELDS_HTTPS_EVERYWHERE_CONTROL_LABEL},
     {"noScriptControlLabel",
       IDS_SETTINGS_BRAVE_SHIELDS_NO_SCRIPT_CONTROL_LABEL},
-    {"lookFeelTitle",
+    {"shieldsLookFeelTitle",
       IDS_SETTINGS_BRAVE_SHIELDS_LOOK_AND_FEEL_TITLE},
     {"showStatsBlockedBadgeLabel",
       IDS_SETTINGS_BRAVE_SHIELDS_SHOW_STATS_BLOCKED_BADGE_LABEL},

diff --git a/...ents/brave_extension/extension/brave_extension/background/reducers/shieldsPanelReducer.ts b/...ents/brave_extension/extension/brave_extension/background/reducers/shieldsPanelReducer.ts
@@ -32,7 +32,6 @@ import {
   requestShieldPanelData,
   onShieldsPanelShown,
   reportBrokenSite,
-  getViewPreferences,
   setAllowScriptOriginsOnce
 } from '../api/shieldsAPI'
 import { reloadTab } from '../api/tabsAPI'