Skip to content

Commit

Permalink
Clear deprecated preference
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexeyBarabash committed Mar 25, 2020
1 parent 7cf7ccf commit 96ba1a4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions components/brave_sync/brave_sync_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

void MigrateBraveSyncPrefs(PrefService* prefs) {
prefs->ClearPref(brave_sync::prefs::kSyncPrevSeed);
prefs->ClearPref(brave_sync::prefs::kDuplicatedBookmarksRecovered);
}

namespace brave_sync {
Expand Down Expand Up @@ -43,8 +44,8 @@ const char kSyncMigrateBookmarksVersion[]
= "brave_sync.migrate_bookmarks_version";
const char kSyncRecordsToResend[] = "brave_sync_records_to_resend";
const char kSyncRecordsToResendMeta[] = "brave_sync_records_to_resend_meta";
// const char kDuplicatedBookmarksRecovered[] =
// "brave_sync_duplicated_bookmarks_recovered"; // deprecated
const char kDuplicatedBookmarksRecovered[] =
"brave_sync_duplicated_bookmarks_recovered";
const char kDuplicatedBookmarksMigrateVersion[] =
"brave_sync_duplicated_bookmarks_migrate_version";

Expand Down Expand Up @@ -76,6 +77,7 @@ void Prefs::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {

registry->RegisterListPref(prefs::kSyncRecordsToResend);
registry->RegisterDictionaryPref(prefs::kSyncRecordsToResendMeta);
registry->RegisterBooleanPref(kDuplicatedBookmarksRecovered, false);
registry->RegisterIntegerPref(prefs::kDuplicatedBookmarksMigrateVersion, 0);
}

Expand Down
2 changes: 1 addition & 1 deletion components/brave_sync/brave_sync_prefs.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ extern const char kSyncRecordsToResend[];
// Meta info of kSyncRecordsToResend
extern const char kSyncRecordsToResendMeta[];
// Flag indicates we had recovered duplicated bookmarks object ids (deprecated)
// extern const char kDuplicatedBookmarksRecovered[]; // deprecated
extern const char kDuplicatedBookmarksRecovered[];

// Version indicates had recovered duplicated bookmarks object ids:
// 1 - we had migrated object ids
Expand Down

0 comments on commit 96ba1a4

Please sign in to comment.