WIP: trying to hide button from positive

brave · Sep 12, 2024 · 9fc47e3 · 9fc47e3
1 parent b3c00dc
commit 9fc47e3
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/browser/resources/settings/brave_overrides/security_page.ts b/browser/resources/settings/brave_overrides/security_page.ts
@@ -56,14 +56,25 @@ RegisterPolymerTemplateModifications({
         } else {
           httpsOnlyModeToggle.setAttribute('hidden', 'true')
         }
-        const secureDnsSettings = enableHttpsFirstModeNewSettings.content.
+      }
+
+      const positiveEnableHttpsFirstModeNewSettings = templateContent.
+        querySelector(
+          'template[is=dom-if][if="[[enableHttpsFirstModeNewSettings_]]"]'
+        )
+      if (!positiveEnableHttpsFirstModeNewSettings) {
+        console.error(
+          '[Brave Settings Overrides] Could not find template with ' +
+          'if=[[enableHttpsFirstModeNewSettings]] on security page.')
+      } else {
+        const showSecureDnsSettings = positiveEnableHttpsFirstModeNewSettings.content.
           querySelector(
             'template[is=dom-if][if="[[showSecureDnsSetting_]]"]')
-        if (!secureDnsSettings) {
-          console.error('[Brave Settings Overrides] Could not find' +
-            'secureDnsSettings on security page.')
+        if (!showSecureDnsSettings) {
+          console.error('[Brave Settings Overrides] Could not find template with ' +
+            'if=[[showSecureDnsSetting_]] on security page.')
         } else {
-          const secureDnsToggle = secureDnsSettings.content.querySelector('settings-secure-dns')
+          const secureDnsToggle = showSecureDnsSettings.content.querySelector('settings-secure-dns')
           if (!secureDnsToggle) {
             console.error('[Brave Settings Overrides] Could not find' +
               'secureDnsToggle on security page.')