Skip to content

Commit

Permalink
SyncService::IsAuthenticatedAccountPrimary -> HasSyncConsent
Browse files Browse the repository at this point in the history
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/ccf421690e5a665cc6d8d6290ac841b21dbd6ca3

commit ccf421690e5a665cc6d8d6290ac841b21dbd6ca3
Author: Marc Treib <treib@chromium.org>
Date:   Tue Oct 19 14:27:33 2021 +0000

    Sync: Replace outdated "authenticated / primary account" terminology

    This CL rename SyncService::IsAuthenticatedAccountPrimary() with
    HasSyncConsent(), and GetAuthenticatedAccountInfo() with just
    GetAccountInfo().

    "Authenticated account" is some outdated terminology that's not used
    in sign-in code anymore.
    More importantly, "primary account" was used here in an outdated
    meaning that wasn't consistent anymore with how it's used in signin
    code.

    This is a pure rename; no behavior changes.

    Bug: 1254280
  • Loading branch information
mkarolin committed Oct 23, 2021
1 parent a503635 commit a190ad6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ TEST_F(
/*disable_features=*/{});
// When we have no primary account, Sync will start in Transport-only mode
// (if allowed).
sync_service_.SetIsAuthenticatedAccountPrimary(false);
sync_service_.SetHasSyncConsent(false);

// Update the active types to only include Wallet. This disables all other
// types, including profiles.
Expand Down

0 comments on commit a190ad6

Please sign in to comment.