Merge pull request #17213 from brave/update_shields_onboarding

Update shields onboarding timing
brave · Feb 19, 2023 · b7fa359 · b7fa359
2 parents 4a187a8 + ec17882
commit b7fa359
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/android/java/org/chromium/chrome/browser/app/BraveActivity.java b/android/java/org/chromium/chrome/browser/app/BraveActivity.java
@@ -1137,7 +1137,6 @@ private void showSearchBoxTooltip() {
                                 if (viewGroup != null && highlightView != null) {
                                     viewGroup.removeView(highlightView);
                                 }
-                                maybeShowNotificationPermissionRetionale();
                             })
                             .modal(true)
                             .contentView(R.layout.brave_onboarding_searchbox)
@@ -1156,7 +1155,7 @@ private void showSearchBoxTooltip() {
         }, 500);
     }
 
-    private void maybeShowNotificationPermissionRetionale() {
+    public void maybeShowNotificationPermissionRetionale() {
         NotificationPermissionController mNotificationPermissionController =
                 new NotificationPermissionController(getWindowAndroid(),
                         new NotificationPermissionRationaleDialogController(

diff --git a/android/java/org/chromium/chrome/browser/toolbar/top/BraveToolbarLayoutImpl.java b/android/java/org/chromium/chrome/browser/toolbar/top/BraveToolbarLayoutImpl.java
@@ -616,6 +616,10 @@ private void showTooltip(String tooltipPref, int tabId) {
                                     highlightView.stopAnimation();
                                     viewGroup.removeView(highlightView);
                                 }
+                                if (BraveActivity.getBraveActivity() != null) {
+                                    BraveActivity.getBraveActivity()
+                                            .maybeShowNotificationPermissionRetionale();
+                                }
                             })
                             .contentView(R.layout.brave_shields_tooltip_layout)
                             .build();