Merge pull request #19752 from brave/issues/32353

Fixes crash in brave_ads::AddTransaction
brave · Aug 17, 2023 · e474398 · e474398
2 parents 19911f8 + 2f0897d
commit e474398
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/components/brave_ads/core/internal/account/transactions/transactions.cc b/components/brave_ads/core/internal/account/transactions/transactions.cc
@@ -24,7 +24,6 @@ TransactionInfo BuildTransaction(const std::string& creative_instance_id,
                                  const AdType& ad_type,
                                  const ConfirmationType& confirmation_type) {
   CHECK(!creative_instance_id.empty());
-  CHECK(!segment.empty());
   CHECK_NE(AdType::kUndefined, ad_type);
   CHECK_NE(ConfirmationType::kUndefined, confirmation_type);
 
@@ -47,7 +46,6 @@ TransactionInfo AddTransaction(const std::string& creative_instance_id,
                                const ConfirmationType& confirmation_type,
                                AddTransactionCallback callback) {
   CHECK(!creative_instance_id.empty());
-  CHECK(!segment.empty());
   CHECK_NE(AdType::kUndefined, ad_type);
   CHECK_NE(ConfirmationType::kUndefined, confirmation_type);