fixes brave/brave-browser#3640, fixes false positive insufficient fun…

…ds notification
brave · Mar 22, 2019 · f47bbbe · f47bbbe
1 parent af85ea6
commit f47bbbe
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/components/brave_rewards/browser/rewards_service.cc b/components/brave_rewards/browser/rewards_service.cc
@@ -48,6 +48,8 @@ void RewardsService::RegisterProfilePrefs(PrefRegistrySimple* registry) {
                                   base::TimeDelta::FromDays(7));
   registry->RegisterTimeDeltaPref(prefs::kRewardsBackupNotificationInterval,
                                   base::TimeDelta::FromDays(7));
+  registry->RegisterTimeDeltaPref(prefs::kRewardsNotificationStartupDelay,
+                                  base::TimeDelta::FromSeconds(30));
   registry->RegisterBooleanPref(prefs::kRewardsBackupSucceeded, false);
   registry->RegisterBooleanPref(prefs::kRewardsUserHasFunded, false);
   registry->RegisterTimePref(prefs::kRewardsAddFundsNotification, base::Time());

diff --git a/components/brave_rewards/browser/rewards_service_impl.cc b/components/brave_rewards/browser/rewards_service_impl.cc
@@ -2340,15 +2340,18 @@ RewardsNotificationService* RewardsServiceImpl::GetNotificationService() const {
 void RewardsServiceImpl::StartNotificationTimers(bool main_enabled) {
   if (!main_enabled) return;
 
-  // Startup timer, begins after 3-second delay.
+  // Startup timer, begins after 30-second delay.
+  PrefService* pref_service = profile_->GetPrefs();
   notification_startup_timer_ = std::make_unique<base::OneShotTimer>();
   notification_startup_timer_->Start(
-      FROM_HERE, base::TimeDelta::FromSeconds(3), this,
+      FROM_HERE,
+      pref_service->GetTimeDelta(
+        prefs::kRewardsNotificationStartupDelay),
+      this,
       &RewardsServiceImpl::OnNotificationTimerFired);
   DCHECK(notification_startup_timer_->IsRunning());
 
   // Periodic timer, runs once per day by default.
-  PrefService* pref_service = profile_->GetPrefs();
   base::TimeDelta periodic_timer_interval =
       pref_service->GetTimeDelta(prefs::kRewardsNotificationTimerInterval);
   notification_periodic_timer_ = std::make_unique<base::RepeatingTimer>();

diff --git a/components/brave_rewards/common/pref_names.cc b/components/brave_rewards/common/pref_names.cc
@@ -18,6 +18,7 @@ const char kRewardsBackupNotificationInterval[] =
 const char kRewardsBackupSucceeded[] = "brave.rewards.backup_succeeded";
 const char kRewardsUserHasFunded[] = "brave.rewards.user_has_funded";
 const char kRewardsAddFundsNotification[] = "brave.rewards.add_funds_notification";
+const char kRewardsNotificationStartupDelay[] = "brave.rewards.notification_startup_delay";
 
 }  // namespace prefs
 }  // namespace brave_rewards
diff --git a/components/brave_rewards/common/pref_names.h b/components/brave_rewards/common/pref_names.h
@@ -17,6 +17,7 @@ extern const char kRewardsBackupNotificationInterval[];
 extern const char kRewardsBackupSucceeded[];
 extern const char kRewardsUserHasFunded[];
 extern const char kRewardsAddFundsNotification[];
+extern const char kRewardsNotificationStartupDelay[];
 
 }  // namespace prefs
 }  // namespace brave_rewards