Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides sites with 0% attention from the A-C table #1032

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Hides sites with 0% attention from the A-C table #1032

merged 1 commit into from
Dec 15, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 6, 2018

Fixes: brave/brave-browser#2365
Native-ledger: brave-intl/bat-native-ledger#199

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Build from this branch and enable rewards
  2. Acquire 0% attention publishers in the AC table (knowingly from an old profile is fine)
    • publisher_info_db can be edited directly to add some
  3. Ensure that these 0% publishers do not show in the AC table

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml self-assigned this Dec 6, 2018
@ryanml ryanml requested a review from NejcZdovc December 6, 2018 10:49
@ryanml ryanml changed the title Fixes brave-browser/issues#2365, filters 0% publishers Hides publishers with 0% attention from the A-C table Dec 6, 2018
@ryanml ryanml changed the title Hides publishers with 0% attention from the A-C table Hides sites with 0% attention from the A-C table Dec 6, 2018
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I modify the database to specify 0%, it still shows in the main list.

(Image sent via Slack. Github not processing images right now for some reason)

@ryanml
Copy link
Contributor Author

ryanml commented Dec 11, 2018

@jasonrsadler - I updated the bat-native ledger PR to add a -1 ALL type for the default constructor, as I think there was a case where we needed, also, I fixed a bad entry in DEPS. This should be good to retest now. Thanks

@ryanml
Copy link
Contributor Author

ryanml commented Dec 12, 2018

@jasonrsadler @NejcZdovc rebased with master - native-ledger updates are now included in this PR

@ryanml ryanml force-pushed the fix-2365 branch 2 times, most recently from a8cd36d to a8012c3 Compare December 14, 2018 23:16
@ryanml ryanml dismissed jasonrsadler’s stale review December 15, 2018 16:31

Review addressed, approved

@ryanml ryanml merged commit 45fd25a into master Dec 15, 2018
@ryanml ryanml deleted the fix-2365 branch December 15, 2018 16:32
@ryanml
Copy link
Contributor Author

ryanml commented Dec 15, 2018

master (0.61): 45fd25a
0.60 d292b92

NejcZdovc pushed a commit that referenced this pull request Dec 17, 2018
Hides sites with 0% attention from the A-C table
NejcZdovc pushed a commit that referenced this pull request Jan 14, 2019
Hides sites with 0% attention from the A-C table
@NejcZdovc NejcZdovc added 0.59.x and removed 0.60.x labels Jan 14, 2019
@NejcZdovc NejcZdovc added 0.60.x and removed 0.59.x labels Jan 14, 2019
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide sites from auto-contribute with 0% contribution.
5 participants