Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Apple Silicon go-ipfs binaries #10364

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Added Apple Silicon go-ipfs binaries #10364

merged 1 commit into from
Oct 7, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 5, 2021

Resolves brave/brave-browser#16912

  • Use ipfs arm64 binary for Apple M1 Macs

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check IPFS node installed and works correcly for win, linux, osx amd64, osx arm64
  • osx arm node extension should have id lejaflgbgglfaomemffoaappaihfligf and contain arm64 node binary

@spylogsster spylogsster self-assigned this Oct 5, 2021
@spylogsster spylogsster force-pushed the issue-16912 branch 4 times, most recently from 2b3f297 to e453868 Compare October 7, 2021 10:42
@spylogsster spylogsster changed the base branch from master to issue-16912-regexp October 7, 2021 11:07
@spylogsster spylogsster changed the title WIP: draft to test Added Apple Silicon go-ipfs binaries Added Apple Silicon go-ipfs binaries Oct 7, 2021
@spylogsster spylogsster requested a review from bbondy October 7, 2021 11:10
@bbondy
Copy link
Member

bbondy commented Oct 7, 2021

seems ci is all failing though

Base automatically changed from issue-16912-regexp to master October 7, 2021 16:05
@spylogsster spylogsster merged commit e90989d into master Oct 7, 2021
@spylogsster spylogsster deleted the issue-16912 branch October 7, 2021 21:35
@spylogsster spylogsster added this to the 1.32.x - Nightly milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-ipfs does not start without Rosetta on Apple Silicon
2 participants