Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DCHECKs to find the root cause of a crash in ads::GetParentSegment #10414

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 7, 2021

Resolves brave/brave-browser#18628

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey modified the milestone: 1.31.x - Beta Oct 11, 2021
@tmancey tmancey force-pushed the issues/18628 branch 2 times, most recently from bdc2081 to 1ef5487 Compare October 13, 2021 14:30
@tmancey tmancey merged commit 488f7fc into master Oct 18, 2021
@tmancey tmancey deleted the issues/18628 branch October 18, 2021 18:23
@tmancey tmancey added this to the 1.33.x - Nightly milestone Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DCHECKs to find the root cause of a crash in ads::GetParentSegment
2 participants