Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wallet UI bugs due to Translated Strings #11123

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixed Various Wallet UI bugs due to Translated Strings

Resolves brave/brave-browser#19349

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before Picture can be viewed in the Issue:

Bildschirmfoto 2021-11-16 um 4 34 23 PM
Bildschirmfoto 2021-11-16 um 4 34 48 PM
Bildschirmfoto 2021-11-16 um 4 38 37 PM
Bildschirmfoto 2021-11-16 um 4 38 58 PM
Bildschirmfoto 2021-11-16 um 4 39 27 PM
Bildschirmfoto 2021-11-16 um 4 34 59 PM

@Douglashdaniel Douglashdaniel self-assigned this Nov 16, 2021
@Douglashdaniel Douglashdaniel merged commit 5257523 into master Nov 17, 2021
@Douglashdaniel Douglashdaniel deleted the fixed-translated-UI-bugs branch November 17, 2021 14:35
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 17, 2021
brave-builds pushed a commit that referenced this pull request Nov 17, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.34.22 Chromium: 96.0.4664.45 (Official Build) nightly (64-Bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 11 Version 21H2 (Build 22000.318)
  • Verified translated strings issues are fixed

  • Panel
    image

  • Lock Wallet
    image

  • Swap Button padding
    image

Custom Gas button

image image

Logged follow up issue #19558

Douglashdaniel added a commit that referenced this pull request Nov 19, 2021
Fixed Wallet UI bugs due to Translated Strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Wallet UI issues due to translated strings
3 participants